Remove state from handle_stream, fixes #119

This commit is contained in:
Lorenz Diener 2018-01-29 12:24:53 +01:00
pare 42b1d8fa58
commit 791439d96b

Veure arxiu

@ -41,40 +41,39 @@ class StreamListener(object):
response; a requests response object with the open stream for reading. response; a requests response object with the open stream for reading.
""" """
self.event = {} event = {}
line_buffer = bytearray() line_buffer = bytearray()
for chunk in response.iter_content(chunk_size = 1): for chunk in response.iter_content(chunk_size = 1):
if chunk: if chunk:
if chunk == b'\n': if chunk == b'\n':
self.handle_line(line_buffer) try:
line = line_buffer.decode('utf-8')
except UnicodeDecodeError as err:
six.raise_from(
MastodonMalformedEventError("Malformed UTF-8"),
err
)
if line == '':
self._dispatch(event)
else:
event = self._parse_line(line, event)
line_buffer = bytearray() line_buffer = bytearray()
else: else:
line_buffer.extend(chunk) line_buffer.extend(chunk)
def handle_line(self, raw_line): def _parse_line(self, line, event):
try:
line = raw_line.decode('utf-8')
except UnicodeDecodeError as err:
six.raise_from(
MastodonMalformedEventError("Malformed UTF-8"),
err
)
if line.startswith(':'): if line.startswith(':'):
self.handle_heartbeat() self.handle_heartbeat()
elif line == '':
# end of event
self._dispatch(self.event)
self.event = {}
else: else:
key, value = line.split(': ', 1) key, value = line.split(': ', 1)
# According to the MDN spec, repeating the 'data' key # According to the MDN spec, repeating the 'data' key
# represents a newline(!) # represents a newline(!)
if key in self.event: if key in event:
self.event[key] += '\n' + value event[key] += '\n' + value
else: else:
self.event[key] = value event[key] = value
return event
def _dispatch(self, event): def _dispatch(self, event):
try: try:
name = event['event'] name = event['event']